[Plugin] Added support for hexadecimal code points to OPDS parser#13482
Merged
Conversation
Frenzie
reviewed
Mar 29, 2025
Frenzie
reviewed
Mar 29, 2025
Member
|
There is a better XML parser hanging around in the codebase btw, but this'll do for the moment. |
Member
|
Thanks! |
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where OPDS parser fails when attempting to fetch from OPDS catalogue that uses hexadecimal code points, eg
', as the parser fails to convert these to numbers.The issue is most likely with KOReader as the OPDS catalogue that was failing to be parsed by KOReader was able to be correctly parsed by other OPDS supported software (eg thorium and moon+ reader) which correctly displayed the codepoint
ɺs an apostrophe'instead of completely failing to parse the page or displaying it as an unknown character.This change is