[Plugin] Statistics plugin calendar and timeline view changed to use color when color rendering is being used #13453
Conversation
NiLuJe
left a comment
There was a problem hiding this comment.
Requires some minor reorganization, but looks otherwise sound ;).
|
Rather non-intrusive in the plugin, so glad @NiLuJe is here to review the painting stuff. From my #11044 (comment) ...
... ALL IS LOŚ͖̩͇̗̪̏̈́T ALL IS LOST the color he comes ̕h̵is un̨ho͞ly radiańcé destro҉ying all enli̍̈́̂̈́ghtenment he c̶̮omes he comes the ichor permeates all MY FACE MY FACE ᵒh god no NO NOO̼OO NΘ stop the an*̶͑̾̾̅ͫ͏̙̤g͇̫͛͆̾ͫ̑͆l͖͉̗̩̳̟̍ͫͥͨe̠̅s ͎ |
|
Created pull request in koreader base repository for additions to BlitBuffer for added colour support: koreader/koreader-base#2047 (comment) |
#2047) Add RGB32 variants for paintBorder and paintRoundedRect functions, currently the paintborder variant doesn't have support to rounded corners. Allows for framecontainers with coloured backgrounds to be used io statistics plugin calendar view. See: koreader/koreader#13453 (comment)
|
I'm curious, was this implemented or is it planned to be? I saw this linked on a reddit thread. I'm not a programmer so I'm having trouble following its progress (and I don't see color calendars in my nightly KOReader from July when the last commit here appears to be March). |
|
I didn't really follow it. @NiLuJe fine to merge for you? |
|
I vaguely remember the base/BB stuff, but I don't recall if I ever actually looked at the front stuff ;p. |
I know it's aesthetics, but it would be cool to have, especially if the code is mostly implemented. |
Frenzie
left a comment
There was a problem hiding this comment.
lgtm, the base necessities were already merged months ago
|
@NiLuJe - Since @Frenzie has approved the changes and noted that "the base necessities were already merged months ago," would you mind taking another look at your requested changes from March to see if they've been addressed or if there are any remaining concerns? It would be great to get this merged into the main build, especially for people on Android where the front-end and ffi folders aren't accessible to modify manually like people on Kobo are able to. Thanks! |
…w when color rendering is enabled (koreader#13453)
Fixes #12899.
As frame container the uses an function in the blitbuffer with no colour equivalent, I temporarily put a colour version in the frame container file as a local function. I think it would be better to move to the blitbuffer file but since that's in the base repository, I wasn't 100% sure how to proceed.
Images:
This change is