Quote directory in util.diskUsage#13448
Merged
Merged
Conversation
Frenzie
reviewed
Mar 23, 2025
Frenzie
approved these changes
Mar 23, 2025
Member
|
Wouldn't it be better to use |
If not quoted, this function does not work with directories that include a space in their name
Author
Have done this now. |
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
If not quoted, this function does not work with directories that include a space in their name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If not quoted, this function does not work with directories that include a space in their name.
I noticed this when using calibre wirelessly. It reports the disk space as 1GB as this is the default if util.diskUsage doesn't work. Adding quotes around the directory fixes it on my Kobo Libra Color.
This change is