Skip to content

Profiles: add "on exiting sleep screen" auto-exec trigger#13430

Merged
hius07 merged 2 commits into
koreader:masterfrom
hius07:profile-auto-exec-sleep-scr
Mar 19, 2025
Merged

Profiles: add "on exiting sleep screen" auto-exec trigger#13430
hius07 merged 2 commits into
koreader:masterfrom
hius07:profile-auto-exec-sleep-scr

Conversation

@hius07

@hius07 hius07 commented Mar 18, 2025

Copy link
Copy Markdown
Member

Useful for delayed or "with a gesture" sleep screen exiting.
Fixes #13399 (comment).

1


This change is Reviewable

@mergen3107

mergen3107 commented Mar 18, 2025

Copy link
Copy Markdown
Contributor

@hius07
Thanks for the PR!
As in itself, it works. Auto exec by time kicks in after I unlock the screen.
However, this is not the same as I had before: #13399 (comment)

  1. I would still get blinded at night if I set high level frontlight and forget by the evening, when I open KOReader in the dark. I'd need to unlock the screen first to let the auto exec work.
  2. That also probably means that all other on wake-up auto exec scripts won't work at all too, if there is gesture to unlock set up.

@hius07

hius07 commented Mar 18, 2025

Copy link
Copy Markdown
Member Author

That's what the sleep screen gesture has been made for:

-- Override handleEvent(), so we can stop any event from propagating to widgets
-- below this one (we may get some from other multiswipe as the handler does
-- not filter the one we are interested with, but also when multiple actions
-- are assigned to a single gesture).

@mergen3107

Copy link
Copy Markdown
Contributor

OK, in that case there should be a warning then that on wake-up events won't fire up if sleep screen is configured to have gesture to unlock.

or on wake-up should be grayed out if that setting is set up.

@mergen3107

Copy link
Copy Markdown
Contributor

I am fine using the dispatcher patch (or maybe also getting blinded at night :D )

@hius07 hius07 merged commit 47ff612 into koreader:master Mar 19, 2025
@hius07 hius07 deleted the profile-auto-exec-sleep-scr branch March 19, 2025 16:53
@hius07 hius07 added this to the 2025.03 milestone Mar 19, 2025
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants