[News Downloader UI] Fix missing elements in the Add feeds window#13415
Merged
Frenzie merged 1 commit intoMar 14, 2025
Conversation
The current code will replace "empty" UI elements with a line. However it is relying on the truthiness of the value of the field. If the value is False, for instance for the "download image" item, then the UI element for that field will be replaced with a line in the UI. This PR just makes sure that we check for explicit "nil" value instead of truthiness. We could also check "value" (and not value[2]) against a constant like `"SEPARATOR="---"` for instance but that would require larger code change.
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
…ow (koreader#13415) The current code will replace "empty" UI elements with a line. However it is relying on the truthiness of the value of the field. If the value is False, for instance for the "download image" item, then the UI element for that field will be replaced with a line in the UI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the News downloader, on the "Edit news feed" screen. Each field to display is stored in a table.
The current code will replace "empty" UI elements with a line (separator). However it is relying on the truthiness of the value of the field. If the value is False, for instance for the "download image" item, then the UI element for that field will be replaced with a line in the UI.
This PR just makes sure that we check for explicit "nil" value instead of truthiness.
We could also check
value(and notvalue[2]) against a constant likeSEPARATOR="---", and use that constant elsewhere in the code, but that would require larger code change.Screenshots
This PR
Master
This change is