You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Any particular reason to have landscape on the left in the dialog and second in the text_func ?
(Given that portrait is the main / most popular orientation, it feels it should be/read first.)
Three reasons:
-lesser value is the first: 10 / 14
-in rotation menus landscape is the first: ⤹ 90°, ↑ 0°
-we place more frequently used buttons in the right part of dialogs (Apply)
I'm fine with having another setting for landscape.
About the reasons, I thought only about the 3rd - but this "rule" makes more sense on "dynamic" or everyday popups (dict result, highlight dialog, ConfirmBox jumping at you) where we want to avoid accidental too-quick tap or bounce. For this setting one, it's not as needed.
The first 2 reasons are less convincing :) (higher value is the first could work too :))
Works like a charm!
I set 20 P and 15 L, and it looks great on PW6's 7-inch screen :)
20/15 is because the screen ratio is roughly 4/3, so the item-height stays about the same in this proportion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12640.
This change is