Skip to content

KeyValuePage: landscape and portrait items per page#13377

Merged
hius07 merged 3 commits into
koreader:masterfrom
hius07:kvp-items-per-page
Mar 9, 2025
Merged

KeyValuePage: landscape and portrait items per page#13377
hius07 merged 3 commits into
koreader:masterfrom
hius07:kvp-items-per-page

Conversation

@hius07

@hius07 hius07 commented Mar 7, 2025

Copy link
Copy Markdown
Member

1

2

Closes #12640.


This change is Reviewable

@poire-z

poire-z commented Mar 7, 2025

Copy link
Copy Markdown
Contributor

Any particular reason to have landscape on the left in the dialog and second in the text_func ?
(Given that portrait is the main / most popular orientation, it feels it should be/read first.)

@hius07

hius07 commented Mar 7, 2025

Copy link
Copy Markdown
Member Author

Three reasons:
-lesser value is the first: 10 / 14
-in rotation menus landscape is the first: ⤹ 90°, ↑ 0°
-we place more frequently used buttons in the right part of dialogs (Apply)

@hius07

hius07 commented Mar 7, 2025

Copy link
Copy Markdown
Member Author

But, maybe it should be discussed: #12640 (comment)

@Frenzie

Frenzie commented Mar 7, 2025

Copy link
Copy Markdown
Member

Indeed first portrait then landscape is more typical.

image

@poire-z

poire-z commented Mar 7, 2025

Copy link
Copy Markdown
Contributor

I'm fine with having another setting for landscape.
About the reasons, I thought only about the 3rd - but this "rule" makes more sense on "dynamic" or everyday popups (dict result, highlight dialog, ConfirmBox jumping at you) where we want to avoid accidental too-quick tap or bounce. For this setting one, it's not as needed.
The first 2 reasons are less convincing :) (higher value is the first could work too :))

@hius07

hius07 commented Mar 7, 2025

Copy link
Copy Markdown
Member Author

Let's start from Portrait as well?

3

4

@poire-z

poire-z commented Mar 7, 2025

Copy link
Copy Markdown
Contributor

No problem with this one. Best here to have the 2 landscape on each side of the main portrait one - and the useless inverted portrait far away.

@mergen3107

Copy link
Copy Markdown
Contributor

Thank you very much @hius07 !
I will test it this evening

@mergen3107

Copy link
Copy Markdown
Contributor

Works like a charm!
I set 20 P and 15 L, and it looks great on PW6's 7-inch screen :)
20/15 is because the screen ratio is roughly 4/3, so the item-height stays about the same in this proportion

@hius07 hius07 merged commit 9f61c23 into koreader:master Mar 9, 2025
@hius07 hius07 deleted the kvp-items-per-page branch March 9, 2025 05:45
@hius07 hius07 added this to the 2025.02 milestone Mar 9, 2025
@Frenzie Frenzie changed the title KeyValuePage: lanscape and portrait items per page KeyValuePage: landscape and portrait items per page Mar 9, 2025
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FR: add "Info lists items per page" to Dispatcher

4 participants