feat(cloudstorage/webdav): Show 'file size' property in WebDAV#13371
Conversation
|
Dropbox list shows the size in the right column. Can it be the same for WebDAV?
|
|
I'm completely new to this codebase, this is my first PR here, so I wasn't aware this was even possible. I've also used the gettext()/_() method to translate the "N/A" string, which I've seen used elsewhere already. Note: I deliberately kept the 
|
|
I think it's redundant in the dialog. |
|
Well, personally, I like to have the information in that dialog as well, that way I don't need to close the dialog if I need to see the file size because of the menu blocking the view. My only real concern would be that the textbox gets too big (due to the additional line breaks) and might cause problems on certain eReaders. Therefore maybe we can just append it at the end of the filename instead. If you also don't like this approach I'm happy to remove it, but I don't really see any reason to not just show it in the dialog as well. |
…d in item popup dialog
|
I vote for having it in the dialog as well - as a reminder right before you hit Download button |
|
I don't mind. Separate lines for filesize looks better for me. |
…e instead in item popup dialog" This reverts commit b28e618.
|
I've reverted the last commit so now it's back to the file size being on its own line, see #13371 (comment). |
| text = item_name, | ||
| url = item_path, | ||
| type = "file", | ||
| filesize = item_filesize |
There was a problem hiding this comment.
tonumber is okay with nil, you can get rid of item_filesize
filesize = tonumber(item_content_length_match),
This PR adds a 'file size' property to the item dialog when selecting an item using Webdav Cloudstorage (see picture).
1) I sadly don't have an FTP/Dropbox/etc. setup to test/implement the other providers, so if someone else could at least make sure it does not cause crashes/other issues I would appreciate it, although the new field should not really affect these providers.
2) I was not sure what to show if the file size can't be queried (also not entirely sure when this would even be the case) so I'm just showing "N/A". If this causes problems with translations I'm happy to adjust it.
Default menu when file size is available:
Forcing the 'item.filesize' to be nil to display 'N/A':
This change is