Skip to content

[ReaderHighlight] NT: account for status and alt-status bars in text selection#13348

Merged
Frenzie merged 1 commit into
koreader:masterfrom
Commodore64user:ts-nt
Mar 2, 2025
Merged

[ReaderHighlight] NT: account for status and alt-status bars in text selection#13348
Frenzie merged 1 commit into
koreader:masterfrom
Commodore64user:ts-nt

Conversation

@Commodore64user

@Commodore64user Commodore64user commented Mar 2, 2025

Copy link
Copy Markdown
Member

what's new

  • frontend/apps/reader/modules/readerhighlight.lua: Modified the logic to account for both the status bar and the alternative status bar, ensuring the highlight indicator does not overlap with these elements.

This change is Reviewable

@Commodore64user Commodore64user changed the title [ReaderHighlight] NT: account for status and alt-status bars [ReaderHighlight] NT: account for status and alt-status bars in text selection Mar 2, 2025
@Frenzie Frenzie added this to the 2025.02 milestone Mar 2, 2025
@Frenzie Frenzie merged commit 316eb87 into koreader:master Mar 2, 2025
@Commodore64user Commodore64user deleted the ts-nt branch March 2, 2025 22:24
@NiLuJe

NiLuJe commented Mar 5, 2025

Copy link
Copy Markdown
Member

Has this been tested with the status bar both with and without reclaim bar height enabled?

@Commodore64user

Commodore64user commented Mar 5, 2025

Copy link
Copy Markdown
Member Author

reclaim is under a isTouchDevice cap, as prior to HotKeys, it was pretty much impossible to use on NT

if Device:isTouchDevice() then
table.insert(sub_items, getMinibarOption("reclaim_height"))

with HotKeys, one could theoretically now toggle the status bar with a shortcut and use the reclaim thingy but I guess I hadn't thought about it until now, after all, I don't reclaim, unlike "@NiLuJe, and for people that do like him." -- @poire-z (2024)

In any case, I just tried it in the emulator and... it seg faults... for clarification, setting the overlap or status bar separator setting does, same thing if running 2024.11.

bash: line 1: 36492 Segmentation fault: 11  EMULATE_READER_W=540 EMULATE_READER_H=720 EMULATE_READER_DPI= ./luajit reader.lua "$@"
make: *** [make/emulator.mk:20: run] Error 139

edit: lifting the cap on k4, it works just fine. Technically you can have the status bar temp drawn over the crosshairs if you: starting with reclaim on but with status bar hidden, start text selection and put the crosshairs at the very bottom of the screen (keep it up), then use a shortcut to toggle the status bar to on. Now the bar is over the crosshairs until a subsequent cursor press. but no biggie.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants