Satisfy FR #13163: Option to hide the "night mode changed" warning#13253
Merged
Conversation
Satisfies the koreader#13163 FR: Hide the AutoWarmth Plugin "Night Mode changed" popup forever koreader#13163
Use spaces because KOReader build does not seem to like tabs.
Frenzie
approved these changes
Feb 13, 2025
Frenzie
left a comment
Member
There was a problem hiding this comment.
Fine by me (barring formatting).
Frenzie
reviewed
Feb 13, 2025
Satisfying koreader#13253 (comment) request.
Contributor
Author
|
Fixed that, I'm not sure what formatting changes are requested but feel free to let me know and I'll work on it. |
Member
|
I think you fixed it in the meantime. |
Change `isTrue()` not needing a default as requested, and also noticed `SaveSettings(_, true)` can use `makeTrue()` to make it a little more clear (it does the same thing but is nicer syntax).
|
Hi @ly-pa, I tested the recent changes you made to the AutoWarmth plugin. The new menu entry to hide the night mode warning appeared as expected, but after applying the change ("Hide this warning permanently"), the popup still showed up when opening a document. I tracked down the issue — the setting was being saved under the wrong key: G_reader_settings:makeTrue("hide_nightmode_warning")But the plugin reads the value from: G_reader_settings:isTrue("autowarmth_hide_nightmode_warning")Because of this mismatch, the setting was never actually applied. Changing the key in |
Frenzie
reviewed
Jun 25, 2025
| text = _("Hide this warning permanently"), | ||
| provider = function() | ||
| self.hide_nightmode_warning = true | ||
| G_reader_settings:makeTrue("hide_nightmode_warning") |
Member
There was a problem hiding this comment.
Suggested change
| G_reader_settings:makeTrue("hide_nightmode_warning") | |
| G_reader_settings:makeTrue("autowarmth_hide_nightmode_warning") |
Frenzie
reviewed
Jun 25, 2025
| end, | ||
| callback = function() | ||
| self.hide_nightmode_warning = not self.hide_nightmode_warning | ||
| G_reader_settings:saveSetting("hide_nightmode_warning", self.hide_nightmode_warning) |
Member
There was a problem hiding this comment.
Suggested change
| G_reader_settings:saveSetting("hide_nightmode_warning", self.hide_nightmode_warning) | |
| G_reader_settings:saveSetting("autowarmth_hide_nightmode_warning", self.hide_nightmode_warning) |
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #13163 FR: Hide the AutoWarmth Plugin "Night Mode changed" popup forever.
It adds 3 simple things:
G_reader_settingscalled"hide_nightmode_warning".This change is