Skip to content

calibre.koplugin: show message when attempting to connect via dispatcher#13237

Merged
Frenzie merged 3 commits into
koreader:masterfrom
pazos:calibre-notify
Feb 12, 2025
Merged

calibre.koplugin: show message when attempting to connect via dispatcher#13237
Frenzie merged 3 commits into
koreader:masterfrom
pazos:calibre-notify

Conversation

@pazos

@pazos pazos commented Feb 11, 2025

Copy link
Copy Markdown
Member

closes #13193

Using an InfoMessage instead of a notification because another infomessage will follow with success/error.


This change is Reviewable

Comment thread plugins/calibre.koplugin/main.lua Outdated
text = _("Connecting to calibre")
})
end)
UIManager:scheduleIn(0.1, function()

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also something like tickAfterNext

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know :)

@Frenzie Frenzie added this to the 2025.02 milestone Feb 11, 2025
@Frenzie Frenzie added the Plugin label Feb 11, 2025

@Frenzie Frenzie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NiLuJe

NiLuJe commented Feb 12, 2025

Copy link
Copy Markdown
Member

Can't check the context right now, but sounds sensible.

I'd maybe prefer a notif regardless because that would allow hiding it, but that's unlikely to ever be done in practice, so fine with me with an IM ;).

@Commodore64user

Copy link
Copy Markdown
Member

Can't check the context right now, but sounds sensible.

I'd maybe prefer a notif regardless because that would allow hiding it, but that's unlikely to ever be done in practice, so fine with me with an IM ;).

We have gone from postponement (having a look during the winter holidays) to outright denial of service ;) nice 👌

@Frenzie Frenzie merged commit a1ac782 into koreader:master Feb 12, 2025
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
…her (koreader#13237)

closes koreader#13193

Using an InfoMessage instead of a notification because another infomessage will follow with success/error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FR: Add "trying to connect to Calibre" display box

4 participants