Exporter: migrate to rapidjson#13204
Conversation
|
I won't be able to test this myself as I never got an error with the highlights I manage on the emulator. I got a confirmation that it no longer crashes w/ rapidjson in #12911 (comment) While I'm not a fan of merging unsupported changes I doubt there's any better alternative here. At best everything works. If I introduced a bug on some target we can fix that later. |
|
Alright, let's merge it so it can be tested a bit more then? |
|
Btw, should the other users also migrate combined with dropping the other JSON or is the situation fine as is? I find it a tad confusing but I haven't followed all of the JSON adventures in detail. |
I think it is fine as long as it doesn't crash :D iirc rapidjson might require some encoding for outliers (ie: rapidjson.null) while the json module handles that on its own. On the particular case of the exporters it seems to fail encoding tables with many arbitrary strings that we don't control (user highlights). But again, I never being able to reproduce the issue. |
|
Alright. 👍 |
Untested
Fixes #12911
Fixes #12820
Fixes #12213
Fixes #9406
This change is