[ReaderFooter] keep menu open after arranging items in status bar#13168
Conversation
|
I'm not necessarily enthusiastic about this concept. The current behavior is that you can nicely order everything, and you can enable and disable at will. After this change, to order would mean to get rid of your order. (That you currently can't see there which is enabled and which is disabled is a slightly separate matter.) |
I was writing the same words. |
|
but I don't think that anyone wants to sort through all the possible items, even those they know they will never use. why should someone arrange 20+ things when they only truly care about 6? furthermore, we don't lose your order, in fact we remember it and if you enable something in the future, it should go back to it's place relative to everything else. edit: for most people, the status quo is like separating the wheat from the chaff. everything that is disabled but still being shown is noise. |
|
Disabling the menu item is good, you can break the loop earlier once the count reaches 2. |
|
👍 |
|
I feel like this is #12929 all over again. It is understandable for you, that know how all of this works, to think that it is fine. However, most users don't know, nor should they have to. I don't quite understand how someone who is always so pro best practices, simple design, good UX, suddenly goes against the very rules he has tried to implement. We don't ask people to User Mental Model and InteractionWhen users select a subset of items from a larger set, their primary cognitive focus is naturally on the items they've chosen. They've deliberately picked these specific items because they're most relevant or interesting to them. This means users are typically most interested in working with, sorting, and managing their selected subset. Cognitive Load ReductionBy presenting users with a view that emphasises their selected items, you reduce the cognitive effort required to interact with the interface. When users see only their chosen items:
mathematically speakingI know that nobody is going to go through all possible combinations, but this sort of illustrates my point of mental fatigue (cognitive load) due to having too much noise
I would like to hear what @poire-z and @offset-torque might have to say about this as well. |
|
Very well said Commodore64user, nothing to add. This might be the only bad UX in KOReader. Thankfully it is a set-once-and-forget kind of setting, but definitely not a nice welcome for the new users. Frenzie has a valid point with this, some users might prefer this model:
So as a compromise, I think these 2 changes can at least improve the procedure without removing items:
Here is a mockup from my test setup. It is immediately obvious which items are in the status bar: Even better is merging the toggle and sort dialogs. So users can toggle the items from this sorting dialog while seeing the result in real time. (Also I am not sure if this is doable, but this is the best UX for this kind of configuration.) |
|
For potential reference, adding a basic indicator of some sort seems simple enough: diff --git a/frontend/apps/reader/modules/readerfooter.lua b/frontend/apps/reader/modules/readerfooter.lua
index 66aaaed59..d26d23c8f 100644
--- a/frontend/apps/reader/modules/readerfooter.lua
+++ b/frontend/apps/reader/modules/readerfooter.lua
@@ -1384,7 +1384,18 @@ function ReaderFooter:addToMainMenu(menu_items)
callback = function()
local item_table = {}
for i=1, #self.mode_index do
- table.insert(item_table, {text = self:textOptionTitles(self.mode_index[i]), label = self.mode_index[i]})
+ local text = self:textOptionTitles(self.mode_index[i])
+ if text then
+ if self.settings[self.mode_index[i]] then
+ text = "A ".. text
+ else
+ text = " " .. text
+ end
+ end
+ table.insert(item_table, {
+ text = text,
+ label = self.mode_index[i],
+ })
end
local SortWidget = require("ui/widget/sortwidget")
local sort_item |
No real thought, no strong opinon either way. |
|
Although, yes indicating which item are selected is somewhat an improvement, I still think it is not as good as simply removing all the noise. There is also another side to the coin; however, annoying as this might be on a device with a touchscreen, it is 2–3× more annoying on NT (Kindle) and perhaps even more so on edit: and we do remember the last position (compare with the original screenshots at the top) edit 2: interesting fact
if that number were money (US dollars), one could buy Apple (the trillion-dollar company) 675 billion times over. |
|
Libreoffice screenshot in Frenzie's message is exactly what I had in mind when writing this:
In that single dialog users can:
They don't have to go to two different menus, one to choose the items and another to sort them. Also this kind of interface can be easily used with NT devices:
|
Funny, I find it an absolute delight on non-touch. On touch I find it mildly annoying; I'd rather just drag & drop more akin to the effortless elegance of non-touch.
It's a problem for someone who's setting it up. But you shouldn't think of it in terms of "all items". Rather in terms of for example 6+4 items. |
is not about pressing buttons per se, that's fine, but there is such a thing as having too much of something. And there is a lot of unnecessary button pressing there. on kindle 2/3 there is also the laaaaaaaaaaaag (let's wait until that catches up), things move at sloweerr speeeeds theeerre.
but that is the thing, the three or four settings I re-enabled went back to their position in the original queue.
I am not sure that would work on |
|
What if there were a "move all inactive to the bottom" in the "Sort A to Z" menu, or something along those lines? (Besides the grayed out or similar.) |
|
That's a good idea Frenzie. I would even say that this can be the default order after installation. Here is a mockup combined with hius07's dimmed items: Users (especially new ones who are not familiar with the items yet) can see which items are currently in the status bar and their order is clear. This is not possible with the current one. |





what's new
keep_menu_openproperty to keep the menu open when arranging one's items. why was this not a thing?enabled_functo ensure the "Arrange items in status bar" option is only enabled when there is more than one enabled item. (on par with dispatcher's)screenshots
This change is