NewsDownloader: deal with 404 and other error statuses better#13165
Merged
Conversation
May be relevant to koreader#9363. In any case one of the most typical kind of failures wasn't treated properly, so a 404 would mess up everything instead of popping up a dialog.
Frenzie
commented
Jan 29, 2025
| if code >= 400 and code < 500 then | ||
| logger.warn("socket error:", status or code) | ||
| if code == 400 then | ||
| return false, "Bad request - invalid URL or parameters" |
Member
Author
There was a problem hiding this comment.
I have no idea what's going on here tbh. It seems incredibly redundant with status. I'll just do:
Suggested change
| return false, "Bad request - invalid URL or parameters" | |
| return false, status or code |
Member
|
I've read it as "40 times better" :p |
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
…er#13165) May be relevant to koreader#9363. In any case one of the most typical kind of failures wasn't treated properly, so a 404 would mess up everything instead of popping up a dialog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
May be relevant to #9363. In any case one of the most typical kind of failure wasn't treated properly, so a 404 would mess up everything instead of popping up a dialog.
This change is