[ReaderHighlight] rewrite some UI strings#13145
Conversation
| table.insert(menu_items.long_press.sub_item_table, { | ||
| text_func = function() | ||
| return T(_("Rate of movement in content selection: %1"), G_reader_settings:readSetting("highlight_non_touch_factor") or 4) | ||
| return T(_("Crosshairs speed for text selection: %1"), G_reader_settings:readSetting("highlight_non_touch_factor") or 4) |
There was a problem hiding this comment.
Crosshair speed (applies everywhere)
There was a problem hiding this comment.
I wasn't completely sure if it was supposed to be singular or plural and according to OED is the latter
1.a. In plural. A pair of fine wires crossing at right angles at the focus of an optical instrument or gunsight for use in positioning, aiming, or measuring; a representation of these wires, usually within a circle, typically on a monitor, screen, etc.
There was a problem hiding this comment.
Both are in use. Looking in COCA many of the plural occurrences are somewhat ambiguous (i.e., "in the crosshairs" rather than "in my crosshairs" — the latter also occurs plenty of course). If you're attached to it we can keep it.
There was a problem hiding this comment.
well even AI agrees "It’s crosshairs—always plural when referring to the visual alignment tool, like in scopes or selection tools." ;)
There was a problem hiding this comment.
AI also says this:
Many professional fields, including military, hunting, and competitive shooting, often use the singular form "crosshair" in their technical documentation and training materials.
NB It may be total nonsense. I wouldn't trust it one way or the other. I get the impression those manuals are more likely to say reticle. It is true, however, that this random manual speaks of a crosshair: https://www.trijicon.com/uploads/page_content/PML1000_Rev0_4x32_3.5x35_Crosshair_ACOG_Manual_.pdf
There was a problem hiding this comment.
Lol that same manual randomly calls them crosshairs 3 times. They should just stick one version of the word.
|
Missing "crosshairs" in the latter form? |
Argg, b*llocks! I’ll add it to the other PR, good catch, thanks @Matthaiks |
what's new
Just a few improvements to UI text, most of them to my very own chagrin.
This change is