Support Kindle Oasis (KOA) charging cover "soda"#13133
Merged
Merged
Conversation
Frenzie
reviewed
Jan 25, 2025
| end | ||
|
|
||
| self.isAuxBatteryConnectedHW = function(this) | ||
| local status = this:read_str_file(self.aux_batt_status_file) |
Member
There was a problem hiding this comment.
You mean there's nothing relevant in /sys/devices/platform/soda/power_supply? On Kobo it's a separate one named conn or some such.
NiLuJe
previously requested changes
Jan 25, 2025
NiLuJe
left a comment
Member
There was a problem hiding this comment.
Besides that very minor comment nit, LGTM, thanks!
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Frenzie and @snajczuk)
frontend/device/kindle/device.lua line 1325 at r1 (raw file):
device = self, fl_intensity_file = "/sys/class/backlight/max77696-bl/brightness", -- NOTE: Points to the embedded battery. The one in the cover is codenamed "soda".
nit: That comment could be rejiggered now that there actually is soda support ;).
| end | ||
|
|
||
| self.isAuxBatteryConnectedHW = function(this) | ||
| local status = this:read_str_file(self.aux_batt_status_file) |
Frenzie
reviewed
Jul 13, 2025
Frenzie
reviewed
Jul 13, 2025
| device = self, | ||
| fl_intensity_file = "/sys/class/backlight/max77696-bl/brightness", | ||
| -- NOTE: Points to the embedded battery. The one in the cover is codenamed "soda". | ||
| -- NOTE: Points to the embedded battery. The one in the cover is codenamed "soda", see aux_batt_capacity_file below. |
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
Much of this code was taken from the Kobo implementation of an auxiliary battery. The biggest difference between the Kobo and Kindle implementation is that the status file for the charging cover is not present when the cover is detached, so the check for status there will result in the file failing to read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the Kindle Oasis (KOA) charging cover, codename "soda".
Much of this code was taken from the Kobo implementation of an auxiliary battery. The biggest difference between the Kobo and Kindle implementation is that the status file for the charging cover is not present when the cover is detached, so the check for status there will result in the file failing to read.
Tested on two Kindles running koreader 2024.11.
This change is