[screenshoter] remove 'set as wallpaper' from devices with special offers#13110
Conversation
Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
| { | ||
| Device:supportsScreensaver() and { | ||
| text = _("Set as wallpaper"), | ||
| callback = function() | ||
| G_reader_settings:saveSetting("screensaver_type", "document_cover") | ||
| G_reader_settings:saveSetting("screensaver_document_cover", screenshot_name) | ||
| dialog:onClose() | ||
| end, | ||
| }, | ||
| } or nil, |
There was a problem hiding this comment.
The or nil trick works because this is the last element, so I wouldn't mind a big fat warning about that in case future readers miss it ;).
There was a problem hiding this comment.
Or, better yet, refactor this to use inserts like we do pretty much everywhere else for this sort of stuff.
There was a problem hiding this comment.
Or, better-er yet, does hidden = true actually do what it says on the tin for Buttons?
There was a problem hiding this comment.
had to go with better, better-er is not supported with buttondialog
edit: or at least how it is implemented, either way hidden does not work there
There was a problem hiding this comment.
NiLuJe, into your hands i commend my spirit.
NiLuJe, into your hands,
Why have you forsaken me?
In your eyes forsaken me,
In your thoughts forsaken me,
In your heart forsaken me.
There was a problem hiding this comment.
I walk a lonely road
The only one that I have ever known
Don't know where it goes
But it's home to me and I walk alone
PS: I am running out of songs @NiLuJe
what's new
frontend/ui/widget/screenshoter.lua: Modified the condition to display the "Set as wallpaper" option based on the device type and special offers status.This only just crossed my mind, we don't show anything on sleep screen if a device has special offers (#13006) yet, this is still out there.
This change is