Skip to content

Collections: filter by book status#13099

Merged
hius07 merged 8 commits into
koreader:masterfrom
hius07:coll-status
Jan 25, 2025
Merged

Collections: filter by book status#13099
hius07 merged 8 commits into
koreader:masterfrom
hius07:coll-status

Conversation

@hius07

@hius07 hius07 commented Jan 19, 2025

Copy link
Copy Markdown
Member

1

2


This change is Reviewable

table.insert(subtitle, self.ui.bookinfo.prop_text[prop] .. " " .. value)
if self.match_table.status then
local status_string = BookList.getBookStatusString(self.match_table.status, true)
table.insert(subtitle, "\u{0000}" .. status_string) -- sorted first

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha! Neat ;).

@NiLuJe NiLuJe Jan 21, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Assuming the font renders a NUL as a zero-width glyph, or not at all, of course).

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's zero-width.
See screenshots in #12981.
"N/A" in the list of tags has the same symbol.

empty_prop = "\u{0000}" .. _("N/A"), -- sorted first

@NiLuJe

NiLuJe commented Jan 21, 2025

Copy link
Copy Markdown
Member

Nothing jumps out at a quick glance ;).

@de3sw2aq1

de3sw2aq1 commented Jan 22, 2025

Copy link
Copy Markdown

I left a comment on the closed PR #12981 (comment) about a bug in the filter by metadata implementation. The fix can probably be added to this PR which is in related code (unless you want a new PR)

Also, I see all these features are being added to collections, which means they're not usable in the main view and isn't a flat view like #8472. Is there a plan to add these filtering options to other views? (I suppose you could add an "All" pseudo-collection. But there's still imitations in the collections view: it's not sortable for example.)

@hius07 hius07 merged commit 42de1fb into koreader:master Jan 25, 2025
@hius07 hius07 deleted the coll-status branch January 25, 2025 08:49
@hius07 hius07 added this to the 2025.01 milestone Jan 25, 2025
Commodore64user pushed a commit to Commodore64user/KOReader_fork that referenced this pull request Jan 27, 2025
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants