[plugin] NewsDownloader: make <title> match less greedy#13070
Merged
Frenzie merged 4 commits intoJan 15, 2025
Conversation
On most pages it works fine, but on pages with multiple </title> it can match very large amounts of text. Valid examples include <svg> in the HTML, where <title> is used similar to title="" in HTML, but of course there could also simply be invalid pages.
…s < that</title> Revert "make it more efficient" This reverts commit aa2b284.
Commodore64user
pushed a commit
to Commodore64user/KOReader_fork
that referenced
this pull request
Jan 27, 2025
On most pages it works fine, but on pages with multiple `</title>` it can match very large amounts of text. Valid examples include `<svg>` in the HTML, where [`<title>`](https://developer.mozilla.org/en-US/docs/Web/SVG/Element/title) is used similar to `title=""` in HTML, but of course there could also simply be invalid pages.
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
On most pages it works fine, but on pages with multiple `</title>` it can match very large amounts of text. Valid examples include `<svg>` in the HTML, where [`<title>`](https://developer.mozilla.org/en-US/docs/Web/SVG/Element/title) is used similar to `title=""` in HTML, but of course there could also simply be invalid pages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On most pages it works fine, but on pages with multiple
</title>it can match very large amounts of text.Valid examples include
<svg>in the HTML, where<title>is used similar totitle=""in HTML, but of course there could also simply be invalid pages.This change is