Skip to content

feat(readerdictionary): add ability to use kiwix standalone#13060

Merged
Frenzie merged 2 commits into
koreader:masterfrom
dtomvan:master
Jan 14, 2025
Merged

feat(readerdictionary): add ability to use kiwix standalone#13060
Frenzie merged 2 commits into
koreader:masterfrom
dtomvan:master

Conversation

@dtomvan

@dtomvan dtomvan commented Jan 13, 2025

Copy link
Copy Markdown
Contributor

Problem: when you install Kiwix from FDroid or as a standalone apk (ergo not via
the Play Store) it installs as org.kiwix.kiwixmobile.standalone, which before
this commit isn't supported.

This commit simply just adds it as a seperate option :)

I know it's a one-line change but I figured I'd just submit it so you can add it if you want, other might benefit from it too.


This change is Reviewable

@Frenzie Frenzie requested a review from pazos January 13, 2025 11:54
Comment thread frontend/device/android/device.lua Outdated
Problem: when you install Kiwix from FDroid or as a standalone apk (ergo not via
the Play Store) it installs as `org.kiwix.kiwixmobile.standalone`, which before
this commit isn't supported.

This commit simply just adds it as a seperate option :)
Co-authored-by: Martín Fernández <975883+pazos@users.noreply.github.com>
@dtomvan

dtomvan commented Jan 14, 2025

Copy link
Copy Markdown
Contributor Author

Had to force push btw because my commit showed up as unknown@gmail.com. Thanks for the review.

@Frenzie Frenzie added this to the 2025.01 milestone Jan 14, 2025
@Frenzie Frenzie merged commit 0c05abb into koreader:master Jan 14, 2025
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
…#13060)

Problem: when you install Kiwix from FDroid or as a standalone apk (ergo not via
the Play Store) it installs as `org.kiwix.kiwixmobile.standalone`, which before
this commit isn't supported.

This commit simply just adds it as a seperate option :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants