[minor] normalize a few requires#13055
Merged
Merged
Conversation
poire-z
approved these changes
Jan 12, 2025
NiLuJe
approved these changes
Jan 12, 2025
Frenzie
added a commit
to Frenzie/koreader
that referenced
this pull request
Jan 15, 2025
I thought I had them all in <koreader#13055> but I seem to have missed a few.
Frenzie
added a commit
that referenced
this pull request
Jan 17, 2025
I thought I had them all in <#13055> but I seem to have missed a few.
Commodore64user
pushed a commit
to Commodore64user/KOReader_fork
that referenced
this pull request
Jan 27, 2025
I thought I had them all in <koreader#13055> but I seem to have missed a few.
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
I thought I had them all in <koreader#13055> but I seem to have missed a few.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't much care what it's resolved to, but right now some places call
require("ui/widget/doublespinwidget")while others callrequire("/ui/widget/doublespinwidget"), and much the same for all the rest. As a result they're easier to accidentally misgrep and loaded twice rather than reused, but that might potentially hide some subtle bugs.This change is