InputDialog: Make sure keyboard_visible is never nil'ed#12994
Merged
Frenzie merged 2 commits intoJan 3, 2025
Conversation
InputText:isKeyboardVisible could return nil when the keyboard was already gone, which cleared the instance variable, meaning we end up with the static class default instead, which is true...
Member
Author
|
Re: #12951 (Completely untested, there might be gnarly codepaths relying on the previously buggy inheritance...) |
Commodore64user
approved these changes
Jan 3, 2025
Member
Author
|
Thanks! I'm hoping that since |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InputText:isKeyboardVisible could return nil when the keyboard was
already gone, which cleared the instance variable, meaning we end up
with the static class default instead, which is true...
This change is