Skip to content

Old plugins cleanup#12932

Merged
pazos merged 5 commits into
koreader:masterfrom
pazos:plugins
Mar 18, 2025
Merged

Old plugins cleanup#12932
pazos merged 5 commits into
koreader:masterfrom
pazos:plugins

Conversation

@pazos

@pazos pazos commented Dec 20, 2024

Copy link
Copy Markdown
Member

Remove OBSOLETE_PLUGINS table.
Remove plugins' paths. Some of them are 4-5y old and shouldn't be there anyways.
Remove exporter settings migration


This change is Reviewable

@Frenzie Frenzie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably fine, though possibly a bit dangerous for hackers (e.g., someone writing a goodreads plugin). ;-)

@Frenzie Frenzie added this to the 2025.01 milestone Dec 20, 2024
@pazos

pazos commented Dec 20, 2024

Copy link
Copy Markdown
Member Author

No hacker was harmed during this PR :)

Obsolete list worked as keywords to avoid, so nobody could use those in their plugins' metadata.

Comment thread frontend/ui/data/onetime_migration.lua Outdated
@Frenzie

Frenzie commented Jan 31, 2025

Copy link
Copy Markdown
Member

@pazos Could you fix the migration conflict? I didn't realize this hadn't been merged yet.

@pazos pazos merged commit fbe2e45 into koreader:master Mar 18, 2025
@pazos pazos deleted the plugins branch March 18, 2025 19:28
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
* Remove OBSOLETE_PLUGINS table.
* Remove old plugins.
* exporter: remove old settings migration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants