ReaderView: speedup highlights drawing#12134
Merged
Merged
Conversation
NiLuJe
approved these changes
Jul 5, 2024
Frenzie
approved these changes
Jul 5, 2024
poire-z
approved these changes
Jul 5, 2024
Commodore64user
pushed a commit
to Commodore64user/KOReader_fork
that referenced
this pull request
Aug 2, 2024
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speedup drawing highlights in cre documents a little bit.
Annotations (highlights) are sorted by position.
Positions in a highlight are sorted (start position (pos1) is before end position (pos2)).
While drawing, the iteration over all highlights can be terminated once the start position of a highlight is bigger than the current page bottom position, it means that this and all next highlights are after the current page.
This change is