Dispatcher: prettify action list#12133
Conversation
|
Did not test, but the code looks good, i like the |
|
Thanks! koreader/frontend/dispatcher.lua Lines 801 to 802 in eaf9712 The default value is taken from the options: koreader/frontend/dispatcher.lua Lines 542 to 544 in eaf9712 |
Frenzie
left a comment
There was a problem hiding this comment.
lgtm besides the two suggestions I left
Look at the second screenshot please. |
Those others also shouldn't be that way; I don't know how that happened. I think they were once automatically taken from the bottom menu rather than manually put in perhaps? |
|
Yes, they are taken from copt and kopt options (bottom menu). |
|
Right, but I meant programmatically. They shouldn't keep the form they have in a different context if they're manual. I think we once allowed it because it was fully automated? Or otherwise I somehow just missed it. ^_^ |
|
You don't even need to jump between different menus to see how the inconsistency stands out. |
Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
(1) New "Use gesture distance" button instead of "When set to 0, the gesture's distance (if any) is used" help text.
(2) Show units in SpinWidgets.
(3) Do not show defaults in SpinWidgets.
(4) koptoptions text and values fixes.
(5) Code tidying.
This change is