[ConfirmBox] remove margin around #12039
Conversation
|
I had this in the back of my mind, but didn't think it's worth time and effort to ask :D Thanks! |
|
I think this was made on purpose, ie. so we can see the border when it is displayed over some black content (ie. some PDF with black background or images). I think we have this behaviour in many places.
No strong opinion which is best. |
|
It looks much better without it (on both dark and light backgrounds). |
|
I think the white border looks better on a device than on this screenshot but yeah I'd do without. |
|
|
||
| local frame = FrameContainer:new{ | ||
| background = Blitbuffer.COLOR_WHITE, | ||
| margin = self.margin, |
There was a problem hiding this comment.
Elsewhere where self.margin is used isn't messed up by this singular removal?
There was a problem hiding this comment.
I have found two more (multiconfirmbox, readerstyletweak). I hope these are all.
The toast messages (Notifications) do have that margin, but these are different anyway.
There was a problem hiding this comment.
Rather I meant within this very file, but in that case the same question applies to those other files.
There was a problem hiding this comment.
May be, it is added to the width of a VerticalSpan.
Or may be not: there, it is used as some vertical "width", for separation between the text and the bottom buttontable. Size.margin.default + Size.padding.default. A bit ugly.
I think it's best to either set margin = 0 instead of Size.margin.default in InputContainer:extend{} (this would allow other widget to set it), or remove every occurence of margin / self.margin.
(InfoMessage does not have any such margin)
There was a problem hiding this comment.
(I meant a white margin around the toast, not the particular margin = ... ;) )
There was a problem hiding this comment.
ConfirmBox:
In my reading, the VerticalSpan in line 165 uses the outer self.margin (which is 5) and it is independent of the FrameContainer margin.
| MovableContainer:new{ | ||
| FrameContainer:new{ | ||
| background = Blitbuffer.COLOR_WHITE, | ||
| margin = self.margin, |
There was a problem hiding this comment.
Here is the same as in ConfirmBox
| FrameContainer:new{ | ||
| background = Blitbuffer.COLOR_WHITE, | ||
| radius = Size.radius.window, | ||
| margin = Size.margin.default, |
There was a problem hiding this comment.
This should be no problem at all.
|
There is more of this nonsense in the |
The current version looks like
But it should look this way
This change is