Skip to content

Styletweaks menu: Ignore ._ files#12022

Merged
Frenzie merged 1 commit into
koreader:masterfrom
jonnyl2:master
Jun 14, 2024
Merged

Styletweaks menu: Ignore ._ files#12022
Frenzie merged 1 commit into
koreader:masterfrom
jonnyl2:master

Conversation

@jonnyl2

@jonnyl2 jonnyl2 commented Jun 13, 2024

Copy link
Copy Markdown
Contributor

Ignore files starting with "._" (metafiles by MacOS), that will otherwise show up in the Styletweaks menu. (These files are alrady ignored in the File manager, even when 'show hidden files' is enabled.)

image

This change is Reviewable

Ignore files starting with "._" (created by MacOS)
@Frenzie Frenzie added this to the 2024.06 milestone Jun 13, 2024
if mode == "directory" then
table.insert(dir_list, f)
elseif mode == "file" and string.match(f, "%.css$") then
elseif mode == "file" and string.match(f, "%.css$") and not util.stringStartsWith(f, "._") then

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinging @NiLuJe

@NiLuJe NiLuJe Jun 13, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dunno if it's worth extending that to unix hidden files, too.

Otherwise, sure, makes sense, macOS resource forks (a.k.a., Apple Double) are a PITA ;).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not aware of anything adding hidden files in that manner, so probably not.

@Frenzie Frenzie merged commit 6400c3a into koreader:master Jun 14, 2024
Commodore64user pushed a commit to Commodore64user/KOReader_fork that referenced this pull request Aug 2, 2024
Ignore files starting with "._" (metafiles by MacOS), that will otherwise show up in the Styletweaks menu. (These files are alrady ignored in the File manager, even when 'show hidden files' is enabled.)
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
Ignore files starting with "._" (metafiles by MacOS), that will otherwise show up in the Styletweaks menu. (These files are alrady ignored in the File manager, even when 'show hidden files' is enabled.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants