Skip to content

add Device:otaModel()#12014

Merged
Frenzie merged 5 commits into
koreader:masterfrom
pazos:ota-model
Jun 25, 2024
Merged

add Device:otaModel()#12014
Frenzie merged 5 commits into
koreader:masterfrom
pazos:ota-model

Conversation

@pazos

@pazos pazos commented Jun 11, 2024

Copy link
Copy Markdown
Member

Devices with a single target might want to specify it in Device.ota_model
Devices with multiple targets want to override the function or to specify ota_model variants for each target.


This change is Reviewable

@pazos

pazos commented Jun 11, 2024

Copy link
Copy Markdown
Member Author

Does "sony-prstux" still receive OTA updates?

@NiLuJe

NiLuJe commented Jun 11, 2024

Copy link
Copy Markdown
Member

Does "sony-prstux" still receive OTA updates?

Nope ;).

@NiLuJe NiLuJe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ;).

@Frenzie

Frenzie commented Jun 11, 2024

Copy link
Copy Markdown
Member

Does "sony-prstux" still receive OTA updates?

No, mainly to save some server space.

@Frenzie Frenzie added this to the 2024.06 milestone Jun 11, 2024
@pazos pazos marked this pull request as draft June 17, 2024 23:09
@pazos pazos marked this pull request as ready for review June 19, 2024 22:48
Comment thread frontend/device/android/device.lua
@Frenzie Frenzie merged commit 617618d into koreader:master Jun 25, 2024
@mergen3107

Copy link
Copy Markdown
Contributor

Did this PR pass all checks?
How come it missed that getZsyncFilename function was not defined at all in otamanager.lua?

Currently there are three calls to it in that file.

@Frenzie

Frenzie commented Jun 28, 2024

Copy link
Copy Markdown
Member

See https://github.com/lunarmodules/luacheck/issues/39.

Commodore64user pushed a commit to Commodore64user/KOReader_fork that referenced this pull request Aug 2, 2024
Devices with a single target might want to specify it in `Device.ota_model`
Devices with multiple targets want to override the function or to specify `ota_model` variants for each target.
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
Devices with a single target might want to specify it in `Device.ota_model`
Devices with multiple targets want to override the function or to specify `ota_model` variants for each target.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants