Skip to content

InputContainer: consistent input type in onInput()#12012

Merged
hius07 merged 8 commits into
koreader:masterfrom
hius07:oninput
Jun 15, 2024
Merged

InputContainer: consistent input type in onInput()#12012
hius07 merged 8 commits into
koreader:masterfrom
hius07:oninput

Conversation

@hius07

@hius07 hius07 commented Jun 11, 2024

Copy link
Copy Markdown
Member

Closes #11990.


This change is Reviewable

@NiLuJe

NiLuJe commented Jun 12, 2024

Copy link
Copy Markdown
Member

Not sure we if we really want to change the variable name (mainly for backwards compat, especially with 3rd-party plugins; otherwise I'd agree with you that the current name isn't great ;)) ;).

Good idea to clean this up, though, thanks!

@hius07

hius07 commented Jun 12, 2024

Copy link
Copy Markdown
Member Author

backwards compat, especially with 3rd-party plugins

They would get the main (letters) layer of the keyboard instead of the numeric (symbol) layer, that's it, not a big issue I believe.

@Frenzie Frenzie added this to the 2024.06 milestone Jun 14, 2024
@hius07 hius07 merged commit ded709e into koreader:master Jun 15, 2024
@hius07 hius07 deleted the oninput branch June 15, 2024 06:54
@Biep

Biep commented Jun 15, 2024

Copy link
Copy Markdown

Just updated a minute ago, but still have issue #11990, so I suppose I still got a nightly from before the update. Will try again tomorrow.

@NiLuJe

NiLuJe commented Jun 15, 2024

Copy link
Copy Markdown
Member

Yup, the merge came juuuust after the nightly build (~6AM GMT) ;).

@Biep

Biep commented Jun 15, 2024

Copy link
Copy Markdown

Hmm.. I just now checked, and got "KOReader is up to date" - but the keyboard issue persists.

@benoit-pierre

Copy link
Copy Markdown
Member

It missed the deadline for the nightly, try tomorrow.

Commodore64user pushed a commit to Commodore64user/KOReader_fork that referenced this pull request Aug 2, 2024
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keyboard in FM starts with special characters

6 participants