Skip to content

[AltStatusBar] Fix when showing (almost) empty#12003

Merged
Frenzie merged 1 commit into
masterfrom
unknown repository
Jun 9, 2024
Merged

[AltStatusBar] Fix when showing (almost) empty#12003
Frenzie merged 1 commit into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Jun 9, 2024

Copy link
Copy Markdown

With enabled battery percentage shown and some other (e.g. reading percentage) the alt status bar shows the expected line. But when disabling everything except battery percentage, then the reading percentage keeps being shown.

So when using this self:page_info_override caching trick, we have to restore the cre default again.


This change is Reviewable

@Frenzie Frenzie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@poire-z Fine by you?

@Frenzie Frenzie merged commit 09822ba into koreader:master Jun 9, 2024
@ghost ghost deleted the fixPageInfoOverrides branch June 10, 2024 05:42
Commodore64user pushed a commit to Commodore64user/KOReader_fork that referenced this pull request Aug 2, 2024
With enabled battery percentage shown and some other (e.g. reading percentage) the alt status bar shows the expected line. But when disabling everything except battery percentage, then the reading percentage keeps being shown.

So when using this `self:page_info_override` caching trick, we have to restore the cre default again.
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
With enabled battery percentage shown and some other (e.g. reading percentage) the alt status bar shows the expected line. But when disabling everything except battery percentage, then the reading percentage keeps being shown.

So when using this `self:page_info_override` caching trick, we have to restore the cre default again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants