Skip to content

Cloud error fix#12000

Merged
Frenzie merged 5 commits into
koreader:masterfrom
mergen3107:Could-Error-Fix
Jun 9, 2024
Merged

Cloud error fix#12000
Frenzie merged 5 commits into
koreader:masterfrom
mergen3107:Could-Error-Fix

Conversation

@mergen3107

@mergen3107 mergen3107 commented Jun 9, 2024

Copy link
Copy Markdown
Contributor

Fixes #11985

It now shows InfoMessage Could not upload file (network error) if upload code is nil.


This change is Reviewable

Comment thread frontend/apps/cloudstorage/webdavapi.lua Outdated
@mergen3107

mergen3107 commented Jun 9, 2024

Copy link
Copy Markdown
Contributor Author

@hius07 @Frenzie
Is this way better?
Tested, no crash, only InfoMessage.

@hius07

hius07 commented Jun 9, 2024

Copy link
Copy Markdown
Member

I think it's not very nice to duplicate the same code comparisons in webdav and webdavapi, but these duplications exist in other methods, so okay.

@mergen3107 mergen3107 changed the title Could error fix Cloud error fix Jun 9, 2024
@Frenzie Frenzie added this to the 2024.06 milestone Jun 9, 2024
@Frenzie

Frenzie commented Jun 9, 2024

Copy link
Copy Markdown
Member

I think it's not very nice to duplicate the same code comparisons in webdav and webdavapi, but these duplications exist in other methods, so okay.

A very similar issue exists in #11970 btw (i.e., my proposed fix there is a half fix but I wanted to take some more time to think about the bigger problem).

@Frenzie Frenzie merged commit 9984f3c into koreader:master Jun 9, 2024
@mergen3107 mergen3107 deleted the Could-Error-Fix branch June 9, 2024 19:27
Commodore64user pushed a commit to Commodore64user/KOReader_fork that referenced this pull request Aug 2, 2024
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cloud upload crash (webdav)

3 participants