Skip to content

Collections: refresh list of files in FileManager#11994

Merged
hius07 merged 2 commits into
koreader:masterfrom
hius07:collection-update-fm
Jun 9, 2024
Merged

Collections: refresh list of files in FileManager#11994
hius07 merged 2 commits into
koreader:masterfrom
hius07:collection-update-fm

Conversation

@hius07

@hius07 hius07 commented Jun 8, 2024

Copy link
Copy Markdown
Member

Since the collection mark is shown, refresh FM list after certain operations on collections.


This change is Reviewable

@Frenzie Frenzie added this to the 2024.06 milestone Jun 8, 2024
@hius07

hius07 commented Jun 8, 2024

Copy link
Copy Markdown
Member Author

Not related, just to illustrate the inconsistency we have with the "check" mark position in select mode in Collections, File searcher, Bookmarks versus the File browser main window.

1

2

3

4

@hius07

hius07 commented Jun 9, 2024

Copy link
Copy Markdown
Member Author

So how do you feel about swapping Home and Plus upper buttons?
And then replacing the "plus" icon with the "appbar.menu" icon?
Full consistency. (but I see some design problems with the folder tree shown in the right)

@poire-z

poire-z commented Jun 9, 2024

Copy link
Copy Markdown
Contributor

So how do you feel about swapping Home and Plus upper buttons?

I'm just so used to it, so well, I like the current layout :)
That said:

And then replacing the "plus" icon with the "appbar.menu" icon?

It would not look too odd: hamburger on the left like in other places, and as no close button needed, the home button there would feel right.

Full consistency. (but I see some design problems with the folder tree shown in the right)

I have no problem with the current inconsistency. The file browser is a "main" app, it does not have a close button, ok, so it gets something else. The check mark is rarely seen/used, so that's not an inconsistency that is in my face.
But indeed, the folder tree would look odd if right aligned. I think you already proposed/mentionned that in the past.

@hius07 hius07 merged commit 786a7e1 into koreader:master Jun 9, 2024
@hius07 hius07 deleted the collection-update-fm branch June 9, 2024 19:34
@hius07

hius07 commented Jun 10, 2024

Copy link
Copy Markdown
Member Author

I think it's time to cancel the star as an annotation marker.
The star marks books in collections and folders with shortcuts.
So we can use the bookmark sign in the SkimWidget and in the status bar:

1

2

3

@Frenzie

Frenzie commented Jun 10, 2024

Copy link
Copy Markdown
Member

Fine by me.

@ichnilatis-gr

ichnilatis-gr commented Jun 15, 2024

Copy link
Copy Markdown
Contributor

I think it's time to cancel the star as an annotation marker.
The star marks books in collections and folders with shortcuts.
So we can use the bookmark sign in the SkimWidget and in the status bar:

Has this change been merged? I don't see it in the latest nightly versions.

@ichnilatis-gr

Copy link
Copy Markdown
Contributor

Pinging @hius07 @Frenzie

@poire-z

poire-z commented Jun 15, 2024

Copy link
Copy Markdown
Contributor

No, not yet, it's just been proposed with a screenshot above for opinions.

@hius07

hius07 commented Jun 15, 2024

Copy link
Copy Markdown
Member Author

Touching the SkimWidget, should I add the compact mode from #11486?
Should we change the letter prefix for bookmarks count in the status bar from BM to A?

@Frenzie

Frenzie commented Jun 15, 2024

Copy link
Copy Markdown
Member

Touching the SkimWidget, should I add the compact mode from #11486?

Could you briefly summarize what that means? But probably, if that's what you want to do. ;-)

Should we change the letter prefix for bookmarks count in the status bar from BM to A?

That would make sense.

@poire-z

poire-z commented Jun 15, 2024

Copy link
Copy Markdown
Contributor

Should we change the letter prefix for bookmarks count in the status bar from BM to A?

Not if standalone. Only if/when/with everything "Bookmarks" becomes "Annotations" (menus, widget title), for consistency.

@hius07

hius07 commented Jun 15, 2024

Copy link
Copy Markdown
Member Author

Could you briefly summarize what that means?

Video in #11486 (comment)

@poire-z

poire-z commented Jun 15, 2024

Copy link
Copy Markdown
Contributor

Video in

May be pick the changes by @jonnyl2 or discuss it with him , he is the main user of it - my original code was just a PoC.
(Glad you're taking it over :) I can remove it from my todo list.)

@Commodore64user

Copy link
Copy Markdown
Member

So, the "display hint" (now a star in top right corner) for books in collections or favourites is always shown regardless of whether you choose to do so or not form settings, is this intentional?

@hius07

hius07 commented Jun 21, 2024

Copy link
Copy Markdown
Member Author

What "settings" do you mean?

@mergen3107

Copy link
Copy Markdown
Contributor

Probably, FM - Top menu - First tab - Settings - Mosaic and detailed list settings - Display hints - Show hint for book status in collections ?

@hius07

hius07 commented Jun 21, 2024

Copy link
Copy Markdown
Member Author

Show hint for book status in collections

It's about showing a hint for book status.

@mergen3107

Copy link
Copy Markdown
Contributor

Ah, so while in collections?

@Commodore64user

Copy link
Copy Markdown
Member

Probably, FM - Top menu - First tab - Settings - Mosaic and detailed list settings - Display hints - Show hint for book status in collections ?

Yes that one.

It's about showing a hint for book status.

What does that mean?

Do i have to live with that star there at the top mocking me without being able to ever hide it?

@hius07

hius07 commented Jun 21, 2024

Copy link
Copy Markdown
Member Author

What does that mean?

Hint for book status (reading, on hold, finished) is shown in the bottom right corner of the book thumbnail (mosaic mode).
This setting shows/hides the hint when browsing collections.

There is no setting to show/hide the collection star, except removing a book from a collection.

@Commodore64user

Copy link
Copy Markdown
Member

Oh yeah, this was going to be Show visual cue for open books in collections in #11792 but 😬 that was discarded so... i now think it would be better as Show visual cue (in collections) for open books

Could we please have an option to hide the star? pretty please.

Commodore64user pushed a commit to Commodore64user/KOReader_fork that referenced this pull request Aug 2, 2024
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants