Calibre Metadata: Some fixes following up #11922#11988
Merged
Merged
Conversation
pazos
reviewed
Jun 6, 2024
Frenzie
approved these changes
Jun 7, 2024
Ditto for self.driveinfo
NiLuJe
commented
Jun 7, 2024
NiLuJe
left a comment
Member
Author
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pazos)
a discussion (no related file):
Previously, pazos (Martín Fernández) wrote…
(Reviewable was unable to map this GitHub inline comment thread to the right spot — sorry!)
it is also an array that holds
driveinfo.calibre
Done.
pazos
reviewed
Jun 7, 2024
pazos
reviewed
Jun 7, 2024
pazos
reviewed
Jun 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue raised by @benoit-pierre revealed that we might have been mangling on-disk metadata files in the Wireless client, so, make sure this doesn't happen again, and update our parser to deal with it without crashing.
Depends on koreader/koreader-base#1816
This change is