Skip to content

Gesture manager: make long-pressing on top left corner non adjustable in FM#11971

Merged
Frenzie merged 1 commit into
koreader:masterfrom
hius07:fm-top-left-corner
Jun 4, 2024
Merged

Gesture manager: make long-pressing on top left corner non adjustable in FM#11971
Frenzie merged 1 commit into
koreader:masterfrom
hius07:fm-top-left-corner

Conversation

@hius07

@hius07 hius07 commented Jun 4, 2024

Copy link
Copy Markdown
Member

It is overridden by the folder tree, so the Gesture manager setting doesn't work.


This change is Reviewable

@hius07 hius07 changed the title Gesture: make long-pressing on top left corner non adjustable in FM Gesture manager: make long-pressing on top left corner non adjustable in FM Jun 4, 2024
@Frenzie Frenzie added this to the 2024.06 milestone Jun 4, 2024
@mergen3107

Copy link
Copy Markdown
Contributor

Sorry, a silly question.
Does the assigned gesture need to be cleared?

For example, for if someone already assigned long-tap on this corner. After this PR this action won't trigger, but should the assigned gesture be cleared out?

@hius07

hius07 commented Jun 4, 2024

Copy link
Copy Markdown
Member Author

After this PR this action won't trigger

This action didn't work before this PR, the folder tree is hardcoded.

@Frenzie Frenzie merged commit bd42f69 into koreader:master Jun 4, 2024
@hius07 hius07 deleted the fm-top-left-corner branch June 5, 2024 04:49
krayushkin pushed a commit to krayushkin/koreader that referenced this pull request Jun 5, 2024
… in FM (koreader#11971)

It is overridden by the folder tree, so the Gesture manager setting doesn't work.
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
… in FM (koreader#11971)

It is overridden by the folder tree, so the Gesture manager setting doesn't work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants