add menu-key-event to 'Menu widget'#11966
Merged
Merged
Conversation
Frenzie
reviewed
Jun 4, 2024
| if Device:hasKeys() then | ||
| -- set up keyboard events | ||
| self.key_events.Close = { { Input.group.Back } } | ||
| self.key_events.LeftButtonTap = { { "Menu" } } |
Member
There was a problem hiding this comment.
LeftButtonTap becomes a bad name if you add this.
Member
Author
There was a problem hiding this comment.
What do you mean by "becomes a bad name"? That is what the existing function is called
Member
There was a problem hiding this comment.
It's changing the original context in which it was named, making it confusing. Something like WidgetMenuToggle? Pinging @hius07 who wrote it for some thoughts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As seen here #11918 (comment)
This change is