QuickMenu: anchor to gesture position 3#10646
Conversation
|
Updates: |
|
Assuming |
|
Thank you for fixing this I think i can simplify this by adding the qm setting to the gesture table in gestures.lua, so we dont need to pass extra arguments. I am not at my computer, so i will hopefully send a patch tomorrow. |
…uickmenu in the ges table.
|
please see e25e0a2 for a simpler way, (i think) and also i moved the gesture specific menus (anchor & always active) to the gesture plugin. If you are ok with it i will push it to this PR branch, and you can take it from there |
|
Thank you, I like the changes, more logical. |
|
Sorry, github is being obtuse, |
| local Notification = require("ui/widget/notification") | ||
| local ReaderHighlight = require("apps/reader/modules/readerhighlight") | ||
| local ReaderZooming = require("apps/reader/modules/readerzooming") | ||
| local Screen = require("device").screen |
There was a problem hiding this comment.
Device.screen
We already require device earlier
yparitcher
left a comment
There was a problem hiding this comment.
looks good, (the dispatcher stuff, i did not look at the ButtonDialog stuff)
poire-z
left a comment
There was a problem hiding this comment.
Taking my part of responsabilities :) : ButtonDialog stuff looks good to me !
A child of #10641.
This change is