PowerD: Unbreak frontlight toggle notifications outside of Kobo#10597
Merged
Conversation
Member
Author
|
Draft because I need more bandwidth to see if I can simply hide the ugliness in Generic's toggleFrontlight (not-the-HW imp one), to leave the messy implementation details solely inside the Kobo imp... Because this thing arguably has zero business being handled in a platform implementation... |
Member
Author
|
Also, dropped the broadcast on Android because it's already handled by the Generic public API, no need to do it twice :?. |
don't leak through to *other* implementations (i.e., leave the Kobo mess in Kobo land, with only a minimal impact on the public API and its implementation).
no return or nil will behave just fine, so forgo an explicit return false to KISS.
Member
Author
|
There, rejiggered the design a bit so that the Kobo implementation details don't leak through to other platform's implementations (e.g., Android). |
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
…ader#10597) Fix koreader#10588 Regression since koreader#10305 While we're there, rejig the FL toggle callback shenanigans so that implementation details don't leak through to *other* implementations. (i.e., leave the Kobo mess in Kobo land, with only a minimal impact on the public API and its implementation).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #10588
Regression since #10305
This change is