Conversation
Frenzie
reviewed
Sep 23, 2017
|
|
||
| -- Android specific | ||
|
|
||
| -- Some Android roms won't load libandroid.so to the global namespace thus |
Member
There was a problem hiding this comment.
Android continues to confound me. :-)
Member
Author
There was a problem hiding this comment.
Didn't know this until I got a Xiaomi Mix. :) And after this fix there will be much less crashes on Android. And the No. 1 issue will be ANR which has something to do with the JIT failure. Hope we can work out that.
Frenzie
pushed a commit
to koreader/koreader-base
that referenced
this pull request
Sep 23, 2017
Frenzie
added a commit
to Frenzie/koreader
that referenced
this pull request
Sep 23, 2017
chrox
added a commit
to chrox/koreader
that referenced
this pull request
Sep 23, 2017
Frenzie
added a commit
to koreader/koreader
that referenced
this pull request
Sep 23, 2017
chrox
added a commit
to chrox/koreader
that referenced
this pull request
Sep 23, 2017
chrox
added a commit
to chrox/koreader
that referenced
this pull request
Sep 23, 2017
chrox
added a commit
to koreader/koreader
that referenced
this pull request
Sep 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Xiaomi MIUI ROMs won't load libandroid.so to the global namespace. We have to load the library by ourselves.