Tolino Epos 2 support#521
Merged
Merged
Conversation
Tolino Epos 2 Device info: Manufacturer: rakuten kobo inc. Brand: rakutenkobo Model: tolino Device: ntx_6sl Product: ntx_6sl Hardware: e80k00 Platform: imx6 test.log Lights: tolino/ntx Also adds Tolino Epos 1 to EPD driver
pazos
reviewed
Oct 7, 2024
| SONY_RP1, | ||
| TAGUS_GEA, | ||
| TOLINO, | ||
| TOLINO_EPOS1, |
pazos
reviewed
Oct 7, 2024
| deviceMap[EinkDevice.SONY_RP1] = SONY_RP1 | ||
| deviceMap[EinkDevice.TAGUS_GEA] = TAGUS_GEA | ||
| deviceMap[EinkDevice.TOLINO] = TOLINO | ||
| deviceMap[EinkDevice.TOLINO_EPOS1] = TOLINO_EPOS1 |
pazos
reviewed
Oct 7, 2024
| DeviceInfo.EinkDevice.RIDI_PAPER_3, | ||
| DeviceInfo.EinkDevice.TOLINO -> { | ||
| DeviceInfo.EinkDevice.TOLINO, | ||
| DeviceInfo.EinkDevice.TOLINO_EPOS1 -> { |
pazos
requested changes
Oct 7, 2024
pazos
left a comment
Member
There was a problem hiding this comment.
I don't understand why you added the Epos1 to EPD. It will still be asigned the first driver of the factory that matches, and I think we agree recently that was TOLINO. So it's a bit of noise.
Contributor
Author
|
Oh sorry, I unfold strings here: My bad. I got confused for to many || or &&. You are right, is catched here: || MODEL.contentEquals(ntx_6sl). |
benoit-pierre
added a commit
to benoit-pierre/koreader
that referenced
this pull request
Oct 12, 2024
Frenzie
pushed a commit
to koreader/koreader
that referenced
this pull request
Oct 12, 2024
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tolino Epos 2
Device info:
Manufacturer: rakuten kobo inc.
Brand: rakutenkobo
Model: tolino
Device: ntx_6sl
Product: ntx_6sl
Hardware: e80k00
Platform: imx6
test.log
Lights: tolino/ntx
Also adds Tolino Epos 1 to EPD driver
This change is