Yes, please move DeviceInfo.LightsDevice.TOLINO_EPOS from TolinoRootController() to TolinoNtxController()

Don't add new identifiers here, Tolino 1 and 2 share epd and lights drivers.

///--///

Or, if you want to document Epos1, create a new definition and use that for both lights and epd. Also rename EPOS to EPOS2

Yes, please move DeviceInfo.LightsDevice.TOLINO_EPOS from TolinoRootController() to TolinoNtxController()

Don't add new identifiers here, Tolino 1 and 2 share epd and lights drivers.

///--///

So, we would do right now then because the following implement exactly like a do :)

        && !HARDWARE.contentEquals("e60k00")
        && !HARDWARE.contentEquals("e60q50")
        && !HARDWARE.contentEquals("e70k00")

Then remove TOLINO_SHINE3, TOLINO_VISION4, TOLINO_VISION5 as well, why not?

Or, if you want to document Epos1, create a new definition and use that for both lights and epd. Also rename EPOS to EPOS2

Then remove TOLINO_SHINE3, TOLINO_VISION4, TOLINO_VISION5 as well, why not?

As I said previously I have no problem with different identifiers for EPOS1 and EPOS2, as long as you use those identifiers to asign proper eink drivers to each one.

The current PR removes the device from being identified as a EPOS, so no longer receives TolinoNTX as its controller.

Then remove TOLINO_SHINE3, TOLINO_VISION4, TOLINO_VISION5 as well, why not?

As I said previously I have no problem with different identifiers for EPOS1 and EPOS2, as long as you use those identifiers to asign proper eink drivers to each one.

The current PR removes the device from being identified as a EPOS, so no longer receives TolinoNTX as its controller.

For EDP driver is not being removed because is catched again here MODEL.contentEquals(STR_TOLINO), worth for all TOLINOS:
EDIT: Is not catched, I misread some parentheses

        TOLINO = BRAND.contentEquals(STR_TOLINO) && MODEL.contentEquals("imx50_rdp")
            || MODEL.contentEquals(STR_TOLINO) && (DEVICE.contentEquals("tolino_vision2")
            || DEVICE.contentEquals(STR_NTX))

In EPDFactory.kt there is no TOLINO_EPOS.

Seems like TOLINO_EPOS is behaving like a generic light driver because is used only in LightsFactory.kt for TolinoRootController.
ref: #239 (comment)

I'll rename TOLINO_EPOS to TOLINO_EPOS2 and TOLINO_EPOS1 add to both EPD and lights driver.

For EDP driver is not being removed because is catched again here MODEL.contentEquals(STR_TOLINO), worth for all TOLINOS:
EDIT: Is not catched, I misread some parentheses

Ah, my bad. You're right.

Let me see if I can search if the EPOS2 was reported once and split those two devices properly without TOLINO_EPOS being the tolino that's not all these other modern tolinos.

Nope. It turns out it was a major @zwim contribution. AFAICT he no longer has the device.

As far as this PR: please do as you like:

1. Stick with TOLINO_EPOS for both 1 and 2 and move it to "lights ntx"
2. Create the new TOLINO_EPOS1 as you did, rename the old one to TOLINO_EPOS2 and move it to "lights ntx" too.
3. Create the new TOLINO_EPOS1 as you did, remove all the references to TOLINO_EPOS and wait for a future report that lets us to identify that device properly.

Nope. It turns out it was a major @zwim contribution. AFAICT he no longer has the device.

As far as this PR: please do as you like:

1. Stick with `TOLINO_EPOS` for both 1 and 2 and move it to "lights ntx"

2. Create the new `TOLINO_EPOS1` as you did, rename the old one to `TOLINO_EPOS2` and move it to "lights ntx" too.

3. Create the new `TOLINO_EPOS1` as you did, remove all the references to `TOLINO_EPOS` and wait for a future report that lets us to identify that device properly.

3

Ready to merge?

Listo

Yep