Skip to content

[wip] Android Fullscreen switcher#50

Merged
houqp merged 2 commits intokoreader:masterfrom
mwoz123:fullscreen_switcher
May 31, 2017
Merged

[wip] Android Fullscreen switcher#50
houqp merged 2 commits intokoreader:masterfrom
mwoz123:fullscreen_switcher

Conversation

@mwoz123
Copy link
Copy Markdown
Contributor

@mwoz123 mwoz123 commented May 29, 2017

Initial commit for Android Fullscreen on/off switch (enable showing android top menu bar).

I'm not sure if those are correct:
"(I)V",
ffi.new('bool'

Help appreciated.

@houqp
Copy link
Copy Markdown
Member

houqp commented May 30, 2017

(I)V should probably work, but (Z)V is more accurate since the java signature actually takes a boolean, see: http://www.rgagnon.com/javadetails/java-0286.html.

@mwoz123
Copy link
Copy Markdown
Contributor Author

mwoz123 commented May 30, 2017

@houqp Thanks, fixed.

@houqp houqp merged commit fa9dd61 into koreader:master May 31, 2017
@houqp
Copy link
Copy Markdown
Member

houqp commented May 31, 2017

Thanks for the patch!

chrox added a commit to chrox/android-luajit-launcher that referenced this pull request Jun 5, 2017
houqp pushed a commit that referenced this pull request Jun 6, 2017
@mwoz123 mwoz123 deleted the fullscreen_switcher branch November 6, 2017 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants