chore(ci): enable modernize:omitzero linter setting
#4981
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4981 +/- ##
==========================================
+ Coverage 75.86% 78.04% +2.18%
==========================================
Files 470 548 +78
Lines 37301 31412 -5889
==========================================
- Hits 28299 24516 -3783
+ Misses 7071 4849 -2222
- Partials 1931 2047 +116 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR enables the modernize:omitzero linter setting in golangci-lint, which enforces the use of omitzero instead of omitempty for zero-value struct fields in JSON tags. The changes add //nolint:modernize annotations to policy definition structs where omitempty must be retained to maintain equivalence with their corresponding policy value structs.
Key Changes:
- Removes the
modernize:omitzerolinter disable rule from.golangci.yml - Adds
//nolint:modernizeannotations to 6 fields across 3 policy definition files whereomitemptyis intentionally used
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.golangci.yml |
Removes the exception that disabled the modernize:omitzero linter check |
snapshot/policy/scheduling_policy.go |
Adds nolint annotations to TimesOfDay and Cron fields to preserve omitempty tags |
snapshot/policy/files_policy.go |
Adds nolint annotations to IgnoreRules and DotIgnoreFiles fields to preserve omitempty tags |
snapshot/policy/compression_policy.go |
Adds nolint annotations to OnlyCompress and NeverCompress fields to preserve omitempty tags |
The
//nolint:modernizeannotations are needed to maintain equivalence between the policy "value" and policy "definition" structs.omitzeroJSON tag in policy structs #4910