refactor(cli): ensure auto-maintenance errors are propagated #4851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that auto-maintenance and repository closing errors are properly propagated rather than being silently logged or overriding previous errors.
- Replaces error logging with error joining to surface auto-maintenance failures
- Preserves original action errors when repository closing fails by joining errors instead of overriding them
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4851 +/- ##
==========================================
+ Coverage 75.86% 76.55% +0.68%
==========================================
Files 470 536 +66
Lines 37301 41167 +3866
==========================================
+ Hits 28299 31514 +3215
- Misses 7071 7607 +536
- Partials 1931 2046 +115 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
julio-lopez
added a commit
to julio-lopez/kopia
that referenced
this pull request
Oct 2, 2025
Prevent running "auto-maintenance" on snapshot create. Ref: - kopia#4851
julio-lopez
added a commit
to julio-lopez/kopia
that referenced
this pull request
Oct 2, 2025
Prevent running "auto-maintenance" on snapshot create. Ref: - kopia#4851
julio-lopez
added a commit
that referenced
this pull request
Oct 2, 2025
Prevent running "auto-maintenance" on snapshot create. Ref: - #4851 Context: the test fails because there are concurrent "endurance" runners and each of these advances the clock, some of them significantly (action{Small,Medium,Large}ClockJump), which causes the clock skewness check to fail when (auto-)maintenance runs. The test maintenance action does not experience this issue because it runs exclusively on its own, that is, other actions have to wait until maintenance completes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure auto-maintenance errors are propagated. This also means that notifications are sent when auto-maintenance fails.
Preserve action error when closing the repository fails.