refactor(notification): replace multierr with errors.Join for error handling #4527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andling Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
bc0f639 to
d8b5379
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4527 +/- ##
==========================================
+ Coverage 75.86% 76.35% +0.48%
==========================================
Files 470 527 +57
Lines 37301 40047 +2746
==========================================
+ Hits 28299 30577 +2278
- Misses 7071 7450 +379
- Partials 1931 2020 +89 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
julio-lopez
added a commit
that referenced
this pull request
Apr 27, 2025
- Replace multierr with errors.Join for error handling - Remove now unused //nolint annotations - Ref: #4527 Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> Co-authored-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Collaborator
|
Thanks @mmorel-35 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
replace multierr with errors.Join for error handling