Skip to content

chore(general): minor cleanups and other nits #4507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
julio-lopez merged 8 commits into from
Apr 17, 2025
Merged

chore(general): minor cleanups and other nits #4507

julio-lopez merged 8 commits into from
Apr 17, 2025

Conversation

@julio-lopez
Copy link
Collaborator

@julio-lopez julio-lopez commented Apr 17, 2025 •
edited
Loading

  • use uint8 for clarity
  • unexport writeContentAsyncAndVerify
  • fix typo in test function names
  • remove commented interface functions
  • use atomic.Int32
  • cleanups in socket server activation test
  • leverage stdlib's maps and slices packages
  • leverage maps.Values

@codecov
Copy link

codecov bot commented Apr 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.32%. Comparing base (cb455c6) to head (1e1b55e).
Report is 473 commits behind head on master.

Files with missing lines Patch % Lines
internal/user/user_manager.go 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4507      +/-   ##
==========================================
+ Coverage   75.86%   76.32%   +0.45%     
==========================================
  Files         470      528      +58     
  Lines       37301    40051    +2750     
==========================================
+ Hits        28299    30568    +2269     
- Misses       7071     7466     +395     
- Partials     1931     2017      +86

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@julio-lopez
Copy link
Collaborator Author

julio-lopez commented Apr 17, 2025 •
edited
Loading

"Mechanical changes", no change in functionality.
Split into individual commits to facilitate the review process

@julio-lopez julio-lopez marked this pull request as ready for review April 17, 2025 06:24
@julio-lopez julio-lopez merged commit 09b88d3 into kopia:master Apr 17, 2025
31 of 32 checks passed
@julio-lopez julio-lopez deleted the misc-nits branch April 17, 2025 06:25
@julio-lopez julio-lopez mentioned this pull request Apr 17, 2025
Merged
julio-lopez added a commit that referenced this pull request Apr 17, 2025
@julio-lopez
chore(ci): enable exptostd linter (#4509)
3712fc4 
Also, cleanup `x/exp/constraints` usage to address linter warning.

Ref:
- #4500
- #4507 (contains prior migration from `x/exp` to stdlib packages)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkowalski jkowalski Awaiting requested review from jkowalski

@redgoat650 redgoat650 Awaiting requested review from redgoat650

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@julio-lopez