Skip to content

fix(server): Add empty line between headers and body in email payload #4414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anaxita wants to merge 1 commit into from
Closed

fix(server): Add empty line between headers and body in email payload #4414

anaxita wants to merge 1 commit into from

Conversation

@anaxita
Copy link

@anaxita anaxita commented Feb 17, 2025

No description provided.

@anaxita anaxita force-pushed the fix-email-message-building branch from 1b3c4a6 to f8af241 Compare February 17, 2025 12:56
@anaxita
Copy link
Author

anaxita commented Feb 17, 2025 •
edited
Loading

This pr fixes a email building by adding a new empty line between body and headers in email message.
False-positive test also fixed (pref: test body already started from new line and it the reason of test passing)

@anaxita
Copy link
Author

anaxita commented Feb 24, 2025

up

@anaxita anaxita force-pushed the fix-email-message-building branch 2 times, most recently from f8af241 to 5f5ab61 Compare February 27, 2025 19:22
@anaxita
Copy link
Author

anaxita commented Feb 27, 2025 •
edited
Loading

@jkowalski Hello, could you tell me about next steps to continue the PR, please?
It's just my first time and I don't know what to do next. As I see some pipelines is required but I don't know how to run it...

@anaxita anaxita mentioned this pull request Feb 27, 2025
Closed
@anaxita
Copy link
Author

anaxita commented Mar 4, 2025

up, please

@anaxita anaxita force-pushed the fix-email-message-building branch 3 times, most recently from 94e42be to b12499a Compare March 7, 2025 21:05
@anaxita anaxita requested a review from jkowalski March 7, 2025 21:06
@anaxita
Copy link
Author

anaxita commented Mar 8, 2025

@jkowalski up

@anaxita
Copy link
Author

anaxita commented Mar 13, 2025

@jkowalski hello?)

@anaxita anaxita force-pushed the fix-email-message-building branch from b12499a to fb842d1 Compare April 12, 2025 11:54
@julio-lopez julio-lopez mentioned this pull request May 1, 2025
Merged
@julio-lopez
Copy link
Collaborator

julio-lopez commented May 1, 2025

julio-lopez added a commit that referenced this pull request May 1, 2025
@julio-lopez
fix(server): add empty line between headers and body in email payload (…
86afca6 
…#4545)

Add empty line between headers and body in email payload.
Fix tests

- Original change: #4414
- Fixes: #4420

---------

Authored-by: Alexandr Kostiuchenko <a.kastsiuchenka>
@julio-lopez
Copy link
Collaborator

julio-lopez commented May 1, 2025

@julio-lopez julio-lopez closed this May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkowalski jkowalski Awaiting requested review from jkowalski

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anaxita @julio-lopez @jkowalski