test(general): add helpers to simplify tests #4191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julio-lopez
commented
Oct 22, 2024
Comment on lines
-68
to
-74
| // verify quick maintenance was run | ||
| sch, err = maintenance.GetSchedule(ctx, env.RepositoryWriter) | ||
|
|
||
| require.NoError(t, err) | ||
|
|
||
| require.NotEmpty(t, sch.Runs, "maintenance runs") | ||
| require.False(t, sch.NextQuickMaintenanceTime.IsZero(), "unexpected NextQuickMaintenanceTime") |
Collaborator
Author
There was a problem hiding this comment.
This was already in the verifyEpochTaskRanInQuickMaintenance helper.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4191 +/- ##
==========================================
+ Coverage 75.86% 76.08% +0.21%
==========================================
Files 470 501 +31
Lines 37301 38483 +1182
==========================================
+ Hits 28299 29280 +981
- Misses 7071 7258 +187
- Partials 1931 1945 +14 ☔ View full report in Codecov by Sentry. |
6d0a7ee to
6b0e01b
Compare
Collaborator
Author
|
Thanks @redgoat650 |
alvistar
pushed a commit
to alvistar/kopia
that referenced
this pull request
Oct 29, 2024
* move common functionality into `verifyEpochTaskRanInQuickMaintenance` helper * add `verifyEpochManagerIsEnabled` helper * add `setRepositoryOwner` helper * rename helper
mcamou
pushed a commit
to mcamou/kopia
that referenced
this pull request
Oct 30, 2024
* move common functionality into `verifyEpochTaskRanInQuickMaintenance` helper * add `verifyEpochManagerIsEnabled` helper * add `setRepositoryOwner` helper * rename helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #4185
Credits to @ashmrtn for the feedback.
Broken down individual changes into separate commits to facilitate review.