fix(repository): allow extending blob retentions #4151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4151 +/- ##
==========================================
+ Coverage 75.86% 77.23% +1.36%
==========================================
Files 470 484 +14
Lines 37301 28867 -8434
==========================================
- Hits 28299 22294 -6005
+ Misses 7071 4667 -2404
+ Partials 1931 1906 -25 ☔ View full report in Codecov by Sentry. |
This was referenced Oct 6, 2024
|
any update? |
Contributor
Author
|
@jkowalski I see you added the generic readonly a few years ago and also the GCS specific read-only (in the original commit) What do you think about just removing the scope variation completely? Removing it has 3 benefits:
Then GCS would use the client default (ScopeFullControl) and the generic |
julio-lopez
reviewed
Oct 16, 2024
Collaborator
julio-lopez
left a comment
There was a problem hiding this comment.
+1: LG 👍
We should get @jkowalski input before merging.
Contributor
|
Thanks for the PR! |
alvistar
pushed a commit
to alvistar/kopia
that referenced
this pull request
Oct 29, 2024
mcamou
pushed a commit
to mcamou/kopia
that referenced
this pull request
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extending a blob requires full control. On the newer client styles (e.g.
option.WithCredentialsJSON(j)), this is the default if no scope is specified.Before:
After: