test(cli): Attempt to fix socket-activated tests #3318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5d96672 to
7f2c7cf
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #3318 +/- ##
==========================================
+ Coverage 75.85% 75.87% +0.01%
==========================================
Files 462 462
Lines 37075 37075
==========================================
+ Hits 28125 28130 +5
+ Misses 7022 7018 -4
+ Partials 1928 1927 -1 ☔ View full report in Codecov by Sentry. |
jkowalski
approved these changes
Sep 19, 2023
julio-lopez
added a commit
to julio-lopez/kopia
that referenced
this pull request
Nov 14, 2025
julio-lopez
added a commit
to julio-lopez/kopia
that referenced
this pull request
Nov 14, 2025
julio-lopez
added a commit
to julio-lopez/kopia
that referenced
this pull request
Nov 14, 2025
julio-lopez
added a commit
that referenced
this pull request
Nov 14, 2025
Objective: make the tests more robust and reduce random failures. Preliminary refactoring: - Accept testing.TB in testenv helpers. This is needed to use `require.EventuallyWithT` in socket activation tests. - Rename parameters for clarity Tests refactoring: - use t.Cleanup instead of defer where appropriate - create file handlers in test routine instead of go routines - remove unnecessary var declaration - increased wait time to 30 seconds. - allow running socket activation test on Darwin Ref: - #3283 - #3313 - #3318
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to make the socket-activated tests more robust by running them in their own process with the proper file-descriptors rather than trying to hack the FDs with syscalls (a method that seems not very robust). The downside is that it requires a kopia executable, which means it can't run with 'go test' (or 'make test') and so I added it to the integration tests (which should still be run as part of CI)
This should fix #3313
The tests run ok for m, but I don't have the CI env, and can't seem to run 'ci-integration-tests' so we'll have to see if it works properly in the workflow.