fix(cli): write CACHEDIR.TAG to log directories #3147
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
can we write the marker to the logs directory directly instead of the parent? The issue is that on Linux logs are under |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3147 +/- ##
==========================================
- Coverage 75.81% 75.40% -0.41%
==========================================
Files 465 459 -6
Lines 37165 36343 -822
==========================================
- Hits 28176 27404 -772
+ Misses 7056 7024 -32
+ Partials 1933 1915 -18
☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Yeah I can change it. Didn't realize that logs are in a different directory on Mac, I don't have access to one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write a CACHEDIR.TAG file to the ~/.cache/kopia directory to exclude cli-logs and address #2822. Get the path to write the cachetag file by going up 1 level from the content cache where it was previously written.