chore(ci): make socket activation test more robust #4985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5c70f7d to
e51494b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4985 +/- ##
==========================================
+ Coverage 75.86% 78.05% +2.19%
==========================================
Files 470 548 +78
Lines 37301 31419 -5882
==========================================
- Hits 28299 24525 -3774
+ Misses 7071 4847 -2224
- Partials 1931 2047 +116 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rationale: needed to use `require.EventuallyWithT` in socket activation tests
Objective: make the test more robust and reduce random failures. Increased wait time to 30 seconds.
e51494b to
daf01c8
Compare
| // RunAndProcessStderr runs the given command, and streams its output line-by-line to a given function until it returns false. | ||
| func (e *CLITest) RunAndProcessStderr(t *testing.T, callback func(line string) bool, args ...string) (wait func() error, kill func()) { | ||
| t.Helper() | ||
| // RunAndProcessStderr runs the given command, and streams its stderr line-by-line to stderrCAllback until it returns false. |
There was a problem hiding this comment.
Corrected spelling of 'stderrCAllback' to 'stderrCallback'.
| // RunAndProcessStderrAsync runs the given command, and streams its output line-by-line to a given function until it returns false. | ||
| func (e *CLITest) RunAndProcessStderrAsync(t *testing.T, callback func(line string) bool, asyncCallback func(line string), args ...string) (wait func() error, kill func()) { | ||
| t.Helper() | ||
| // RunAndProcessStderrAsync runs the given command, and streams its stderr line-by-line stderrCAllback until it returns false. |
There was a problem hiding this comment.
Corrected spelling of 'stderrCAllback' to 'stderrCallback'.
| t.Fatal("server did not exit in time") | ||
| } | ||
|
|
||
| require.True(t, gotExpectedErrorMessage.Load(), "expected server's stderr to contain a line along the lines of 'Too many activated sockes ...'") |
There was a problem hiding this comment.
Corrected spelling of 'sockes' to 'sockets'.
Suggested change
| require.True(t, gotExpectedErrorMessage.Load(), "expected server's stderr to contain a line along the lines of 'Too many activated sockes ...'") | |
| require.True(t, gotExpectedErrorMessage.Load(), "expected server's stderr to contain a line along the lines of 'Too many activated sockets ...'") |
julio-lopez
added a commit
to julio-lopez/kopia
that referenced
this pull request
Nov 14, 2025
- follow-up to kopia#4985
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective: eliminate, or at least reduce, failures in unreliable test.
Primary change in: 447f3f3
Preliminary refactoring was required to change the parameter type from
*testing.Ttotesting.TBin various helpers.Ref: